Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Relive Timelens support #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RFC: Relive Timelens support #83

wants to merge 2 commits into from

Conversation

florolf
Copy link
Member

@florolf florolf commented Oct 30, 2018

Add timelens support for Relive recordings. This works similarly to the current scrub thumbs, but is mutually exclusive with it as both features overlap technologically as well as from a user perspective.

Currently, the Timelens CSS gets added dynamically because loading it indiscriminately results in artifacts in the player. Not sure if we either need a portable way to do this in JS (h() cannot be used, as it's a PHP function and templating the JS with PHP doesn't seem to be a sane solution) or if this can be fixed on the Timelens side. Comments welcome.

Copy link
Member

@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants